Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: kill in time when to mergeGlobalTopN with partition (#45707) #45708

Merged
merged 1 commit into from
Aug 1, 2023
Merged

statistics: kill in time when to mergeGlobalTopN with partition (#45707) #45708

merged 1 commit into from
Aug 1, 2023
+3 −0

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45707

What problem does this PR solve?

Issue Number: close #45706

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei @ti-chi-bot
statistics: kill in time when to mergeGlobalTopN with partition
46fa46a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 1, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 1, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2023
@hawkingrei hawkingrei requested a review from winoros August 1, 2023 09:22
@hawkingrei
Copy link
Member

/retest

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@05d7505). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #45708   +/-   ##
================================================
  Coverage               ?   73.6759%           
================================================
  Files                  ?       1082           
  Lines                  ?     347006           
  Branches               ?          0           
================================================
  Hits                   ?     255660           
  Misses                 ?      74917           
  Partials               ?      16429

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [time-and-fate,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 08:07:00.591696748 +0000 UTC m=+172704.534045344: ☑️ agreed by time-and-fate.
  • 2023-08-01 11:20:27.635833049 +0000 UTC m=+184311.578181580: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 40cfe57 into pingcap:release-6.5 Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@winoros winoros winoros approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

@hawkingrei hawkingrei

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @hawkingrei @winoros @time-and-fate